More...

Rust crate for logging to LogDNA

Bug reports and pull requests are welcome on GitHub at

Rust crate for logging to LogDNA

Contributing

Bug reports and pull requests are welcome on GitHub at https://github.com/logdna/logdna-rust.

License

The crate is available as open source under the terms of the MIT License.

Issues

Collection of the latest Issues

peter-kehl

KeyValueMap easier to populate/transform to

Thank you for Tags::parse(..).

We probably don't need/want any out-of-the box parsing for key-value pairs, since the separators... may vary. But how about

KeyValueMap::new(given_map: HashMap) that would take its ownership (especially since the current implementation is a wrapper), and optionally:
a conversion function like KeyValueMap::new(it: Iterator<Item = (impl String, impl String)>) -> Self? (Or implementing TryFrom, but something tells me that TryFrom is not a good way to go here.)

peter-kehl

KeyValueMap, Params, RequestTemplate and Client: Clone?

Hi at LogDNA/Mezmo crate maintainer/creator,

Thank you for this Rust library. It works marvels.

I see that you guard your API, to make it future proof/implementation-independent. Like KeyValueMap is a value type around HashMap, rather than HashMap itself.

If you didn't intend KeyValueMap to be Clone, you may want to make it a one-field struct {} rather than a one-field tuple, because a tuple automatically is Clone or even Copy (and I believe it's automatically Debug, too) if all its fields are Clone or Copy (or Debug). Of course, you may have intended KeyValueMap to be Clone, which I'd be thankful for. (I've checked and there are no other named tuples around: egrep -r "struct +[a-zA-Z_]+ *\(" src.)
On the other hand, Clone is very handy. For example, Axum requires the (HTTP GET/POST...) service handler function/closure to be Clone (https://docs.rs/axum/latest/axum/handler/trait.Handler.html). Currently there's no way to instantiate one Client, use it before spinning up Axum and pass it to the handler(s), too.