Filter might return duplicate results when the internal objects are similar.

e.g. input JSON both objects have name == {"first":"A","middle":"A"}

When running:

The following result is returned:

It seems like the bug is in this code which compares all the candidates with all values and return each "parent" twice. https://github.com/freestrings/jsonpath/blob/1a84c5af9445e617a6deed14dadfaee13af0d95f/src/select/expr_term.rs#L107

ref https://github.com/RedisJSON/RedisJSON/issues/667

Path:

JSON:

jsonpath matches to []

Expected:

(from jayway, via https://jsonpath.herokuapp.com/)

Path such as $.store.book[0]category Does not throw an error and is silently ignoring the surplus text category beyond the ] And is parsed as $.store.book[0]

Can be demonstrated also on https://freestrings.github.io/jsonpath/ The same value is returned with and without the surplus text category. Parser should throw an error on surplus text.

Notice that If there is a dot delimiter before the surplus text then everything is OK, e.g., $.store.book[0].category is working as expeced.

Adding a test such as the following, fails when a filter contains an OR expression with one of its operands being compared to a none-existing value, e.g., Slightly modifying an existing test named op_object_or_default in op.rs:

The selected result is empty, while it should be equal to the target json.

When removing the right operand || == 4 it succeeds (with filter >= 2)]" )

Hi,

I discovered the following panic while using SelectorMut::remove:

The jsonpath_lib version is 0.3.0. Here is a minimal reproducer:

I expected mutated to contain an empty array, but got this panic instead. Please note that when using .delete() instead of .remove() this code does not panic but produces the expected result of an array which contains only nulls.

I suspect that the array length isn't recalculated correctly after removing elements.

Hi, first of all thank you very much for this crate, helped me a lot.

I recently had to implement something where I had a bunch of partial json objects, each with its associated json path, and I had to build a json object from all those partial ones. In order to do this I had to parse each json path backwards in order to build my final json object. My code lies here.

But traits for doing this are not public. In the end, I would love to have those public use jsonpath_lib::{ParserNodeVisitor, ParserTokenHandler, ParseToken, StrRange};. I get that it is not the main purpose of the crate ; it is not aimed at being a parser.

I am willing to open a PR for that, I just wanted to have your consent (and explain why). WDYT ?

Thank you very much

e.g.

Example JSON:

ref https://github.com/RedisJSON/RedisJSON/issues/494

The following path returns both books despite the fact none has lastName1 attribute.

Example JSON:

ref https://github.com/RedisJSON/RedisJSON/issues/494

ref https://github.com/RedisJSON/RedisJSON/issues/494

Checks if a string contains the specified substring (case-sensitive), or an array contains the specified element.

The following path crash due to Accessing address: (nil)

Example JSON:

The following test fails due to the $.prod:id path

Returning an empty array []

Today the code assumes the underline json structure is serde_json::Value. We have a situation where this is not the case and we need to work with a custom structure. We still want to use this library with our structure. I was wondering if you will accept a PR that changes the code to work with any value that implement a defined trait, this way it can be use with serde_json::Value but with other structures as well. If you agree we can use this issue to define the details and I will be happy to contribute the PR.

I would like to get the keys of the matching objects. For example, when I have the following JSON:

I want to get ["a","b"] with the following selector:

I know it's Jsonpath-Plus. But does this library support it? Is there any plan to go that way? Is there any way I achieve my goal with the current code?

@cburgmer's JSONPath comparison project is currently discussing some issues relating to a proposed implementation of JSONPath known as "Proposal A". May I encourage you to get involved if you are interested in influencing the direction or, indeed, if you want to make your own proposals.

Similarly, please join us in slack (invitation) for informal discussions on the comparison project and potential JSONPath standardisation.

All examples for this library are around vectors. Not a single example shows how to fetch just a specific value from json using jsonpath. If select returns vector everytime, how would program know if returned value was actually an json array or json value?

Also there is incosistency in the results returned by select and select_as_str

I have below json. For json path $.args.foo1, select_as_str() returns "[\"bar1\"]" which is ofcourse wrong and select() doesn't return anything!! but empty array

In v0.2.3 Node was public, but is no longer exposed.

Unfortunately this breaks code in a semver incompatible way.

I'm using Parser::compile directly and need to store the returned Node. Parser is still exposed but not Node

JSON: {"fi":[{"code":"1"}, {"code":"2"}]}

JSONPath:

Current replace_with code seems very inefficient

1. Find all values.
2. Compute all paths from values found in (1)
3. Find values to replace again using paths from (2) to replace

It seems like the replace should account in step (1) while running select()

e.g.

Add $.a.c=2 to:

Is there a way to get how many Values where deleted? or know if delete succeeded to delete?

e.g.

delete $.a.c including removing c and not setting NULL in c

to